Separate client and server watchers #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can you rename the commit to follow the guidelines? https://github.com/DaftMonk/generator-angular-fullstack/blob/master/contributing.md e.g: feat(app): Separate client and server watchers |
|
Sure, apologies for that. |
|
Cool, thanks. |
DaftMonk
added a commit
that referenced
this pull request
Nov 21, 2013
Separate client and server watchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the watch into two; client and server. Client-side changes don't require a node restart, so they only trigger a LiveReload.
The
livereload: truein theexpresstarget is optional. You could decide that server-side changes don't require a reload, but there is a use case for leaving it in too, so I've left it.